Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code blocks to the ch17 (practicing-bdd) #30

Merged
merged 1 commit into from
Nov 13, 2015
Merged

Conversation

bocharsky-bw
Copy link
Member

Resolve 17-practicing-bdd in #12

weaverryan added a commit that referenced this pull request Nov 13, 2015
Add code blocks to the ch17 (practicing-bdd)
@weaverryan weaverryan merged commit 430f52f into behat3 Nov 13, 2015
@weaverryan weaverryan deleted the code-blocks-ch17 branch November 13, 2015 17:03
@weaverryan
Copy link
Member

@bocharsky-bw sometimes, there's 1 line between 2 lines that we want to show. I think if that line is blank (or has something else not important, like a comment), we should show it. That way, I can see that it is just a blank line - if I see the ... in the code block (which takes up the same amount of space), it's less clear what details we're hiding :). For example, line 34 is just a blank line:

screen shot 2015-11-13 at 12 06 48 pm

@weaverryan
Copy link
Member

And on that same code-block, I added the if statement context around it. This gives it more context "where does this go?" - but as a negative, the code block is now a mix of new stuff and old stuff. Here's what I changed the block to:

screen shot 2015-11-13 at 12 08 12 pm

What is your opinion of doing this?

@bocharsky-bw
Copy link
Member Author

@weaverryan Hm, it's really difficult question. I have not thought well about this before... I think more context is worth mix of new / old stuff here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants