Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSubClient: Add failure test into readByte() #988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PubSubClient: Add failure test into readByte() #988

wants to merge 1 commit into from

Commits on Dec 28, 2022

  1. PubSubClient: Add failure test into readByte() 

    _client->read() returns a signed int which can fail if the underlying stream is implemented as such.

e.g. TinyGsmTCP::read() is implemented to return a -1 on failure

int read() override {
uint8_t c;
if (read(&c, 1) == 1) { return c; }
return -1;
}

Signed-off-by: Alex J Lennon <[email protected]>
    @ajlennon
    ajlennon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    ed670c0 View commit details
    Browse the repository at this point in the history