Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to kube codegen #15491

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Migrate to kube codegen #15491

merged 1 commit into from
Sep 3, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Sep 2, 2024

Fixes #

Proposed Changes

  • Check here and here. Right now code gen is broken.
  • Similar to Migrate to kube_codegen.sh eventing#8183, deep-gen also has changed a bit.
  • Tested by removing files under ./pkg/client and under dirs where zz_generated.deepcopy.go files are created.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 2, 2024
@skonto skonto requested a review from dsimansk September 2, 2024 14:46
@@ -0,0 +1,22 @@
//go:build !ignore_autogenerated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by the tool.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (5f5f6d8) to head (6154caf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15491      +/-   ##
==========================================
- Coverage   84.49%   84.47%   -0.02%     
==========================================
  Files         219      219              
  Lines       13608    13608              
==========================================
- Hits        11498    11496       -2     
- Misses       1740     1742       +2     
  Partials      370      370              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor

dsimansk commented Sep 3, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
Copy link

knative-prow bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@knative-prow knative-prow bot merged commit 372f5d1 into knative:main Sep 3, 2024
68 checks passed
@skonto skonto mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants