Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the scorecard github action and its badge #15473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshitasao
Copy link

Fixes knative/community#1592

Proposed Changes

PR to add the Scorecard GitHub Action and its badge in the README file.

Release Note

NONE

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2024
Copy link

knative-prow bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshitasao
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

knative-prow bot commented Aug 16, 2024

Welcome @harshitasao! It looks like this is your first PR to knative/serving 🎉

Copy link

knative-prow bot commented Aug 16, 2024

Hi @harshitasao. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto August 16, 2024 19:47
@harshitasao
Copy link
Author

cc @davidhadas

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (c51ee6c) to head (e17210f).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15473      +/-   ##
==========================================
+ Coverage   84.44%   84.46%   +0.02%     
==========================================
  Files         219      219              
  Lines       13608    13608              
==========================================
+ Hits        11491    11494       +3     
+ Misses       1744     1743       -1     
+ Partials      373      371       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Oct 7, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2024
@skonto
Copy link
Contributor

skonto commented Oct 7, 2024

@davidhadas gentle ping

@skonto skonto added this to the v1.16.0 milestone Oct 7, 2024
@davidhadas
Copy link
Contributor

davidhadas commented Oct 7, 2024

@harshitasao

I suggest we separate this PR into 2 parts:

First, lets add the Scorecard GitHub Action << I am ok with the suggested changed to .github
(also, if you have a way to add a comment in the Scorecard indicating "this scorecard is under community evaluation" - please do so, can it be done by changing the scoreboard title?)

Then, lets resolve all pending issues with the Scorecard such as those indicated in #15474

Last, when the community is ok with the Scorecard, we can add the comment and badge to the community readme file.

I therefore suggest to remove the changes to the readme (and badge) from this PR and add it in a future PR when the Scorecard is community approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Enable OpenSSF Scorecard to enhance security practices across the project
3 participants