-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation about Knative serving encryption #14213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I left a few comments. But they are just nit, it is alright without fix them.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #14213 +/- ##
==========================================
+ Coverage 86.18% 86.21% +0.02%
==========================================
Files 199 195 -4
Lines 14811 14704 -107
==========================================
- Hits 12765 12677 -88
+ Misses 1741 1726 -15
+ Partials 305 301 -4 ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
/approve |
/hold |
/lgtm |
@dprotaso can this be merged? Some Approver magic is needed. |
Thanks @ReToCode , looks good to me. I think it reflects well the current status and also give an outlook to the parts that are still missing. |
/assign @dprotaso |
Looks good - though I notice the diagrams don't display text well in dark mode. (it's black on black) |
Good point, backgrounds were transparent, I changed it to white. |
@dprotaso gentle ping |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, kvmware, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
As we had several discussions in the past, this is an try to summarise and visualise how the different Serving encryption workstreams can align. Please note, this ONLY contains the work of the tracking issue #11906 and omits the mTLS stuff (for now). I'll also update the issues we have to hopefully get a more clear roadmap how we can achieve what is described in that document.
PTAL @davidhadas , @KauzClay , @dprotaso , @skonto , @nak3, @rhuss