-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to filter objects on injection controller promotion #2170
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2170 +/- ##
==========================================
+ Coverage 65.88% 65.92% +0.04%
==========================================
Files 223 223
Lines 9385 9398 +13
==========================================
+ Hits 6183 6196 +13
Misses 2921 2921
Partials 281 281
Continue to review full report at Codecov.
|
Currently we enqueue every object with no way to filter, which causes problems for eventing's source controller which reconciles duck CRDs.
048e517
to
e15d370
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benmoss The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
👍 that PR looks like a better approach, let me follow up with that |
/open |
/reopen |
@benmoss: Failed to re-open PR: state cannot be changed. The filter-promote-func branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently we enqueue every object with no way to filter, which causes problems for eventing's source controller which reconciles duck CRDs.
ref: knative/eventing#5543