-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s api to v0.27.6
and contour to 1.26.0
#974
Bump k8s api to v0.27.6
and contour to 1.26.0
#974
Conversation
Codecov Report
@@ Coverage Diff @@
## main #974 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 7 7
Lines 802 802
=======================================
Hits 753 753
Misses 28 28
Partials 21 21 |
/test build-tests |
a870215
to
8366a86
Compare
/test integration-tests |
/lgtm |
/hold - we should actually bump to the right k8s client-go version - for v1.12 that's 1.27.x |
Might want to wait for this bump first |
@andrew-su all the stuff has merged - so you're good to continue |
8366a86
to
4fadd8c
Compare
Updated.
Should I bump it to ^ or leave it for consistency? |
We can match serving with v0.27x deps. Next release we are targeting k8s min version of 1.26 which means we can use 1.27 libs https://github.com/knative/serving/blob/6703812f131472daa5b7f17e60dd7f49a06c1ead/go.mod#L28 |
1.26.0
v0.27.6
and contour to 1.26.0
/retest |
799d901
to
f18b0a0
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrew-su, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Changes
1.26.0
0.27.6
kube-openapi
to be the same version used byk8s.io/[email protected]
.>= 0.28.0
) causes a dependency issue asgithub.com/google/gnostic
had been split out intogithub.com/google/gnostic-models
code-generator
to bev0.27.6
.k8s.io/code-generator
executesgenerate-internal-groups.sh
which we currently do not set the exec flag from theknative.dev/hack
module. (To be removed when Updatecodegen-library.sh
to set exec flag on new k8s.io/code-generator scripts knative/hack#335 or Usekube-codegen.sh
instead ofgenerate-groups.sh
when moving to k8s.io api0.28+
knative/hack#336 is done)/kind enhancement
Fixes #960