Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove unused TLS references for the integration sink #8378

Closed
wants to merge 1 commit into from
Closed

Chore: Remove unused TLS references for the integration sink #8378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions config/core-tls/integration-sink-tls-certificate.yaml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions pkg/eventingtls/eventingtls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ const (
BrokerFilterServerTLSSecretName = "mt-broker-filter-server-tls" //nolint:gosec // This is not a hardcoded credential
// BrokerIngressServerTLSSecretName is the name of the tls secret for the broker ingress server
BrokerIngressServerTLSSecretName = "mt-broker-ingress-server-tls" //nolint:gosec // This is not a hardcoded credential

// IntegrationSinkDispatcherServerTLSSecretName is the name of the tls secret for the integration sink dispatcher server
IntegrationSinkDispatcherServerTLSSecretName = "integration-sink-server-tls" //nolint:gosec // This is not a hardcoded credential
)

type ClientConfig struct {
Expand Down
5 changes: 0 additions & 5 deletions pkg/reconciler/integration/sink/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import (
secretinformer "knative.dev/pkg/injection/clients/namespacedkube/informers/core/v1/secret"

integrationsinkreconciler "knative.dev/eventing/pkg/client/injection/reconciler/sinks/v1alpha1/integrationsink"
"knative.dev/eventing/pkg/eventingtls"
kubeclient "knative.dev/pkg/client/injection/kube/client"
"knative.dev/pkg/configmap"
"knative.dev/pkg/controller"
Expand Down Expand Up @@ -82,10 +81,6 @@ func NewController(
globalResync = func(interface{}) {
impl.GlobalResync(integrationSinkInformer.Informer())
}
secretInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
FilterFunc: controller.FilterWithName(eventingtls.IntegrationSinkDispatcherServerTLSSecretName),
Handler: controller.HandleAll(globalResync),
})

deploymentInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
FilterFunc: controller.FilterControllerGVK(v1alpha1.SchemeGroupVersion.WithKind("IntegrationSink")),
Expand Down
Loading