-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused filter function #8375
Remove unused filter function #8375
Conversation
Signed-off-by: Matthias Wessendorf <[email protected]>
/assign @pierDipi |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8375 +/- ##
==========================================
+ Coverage 64.14% 64.16% +0.01%
==========================================
Files 389 388 -1
Lines 23335 23329 -6
==========================================
Hits 14969 14969
+ Misses 7571 7565 -6
Partials 795 795 ☔ View full report in Codecov by Sentry. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Having the same in pkg: https://github.com/knative/pkg/blob/f3ab5605e542aa36cf45056e58724ecf426202ef/reconciler/filter.go#L64-L71
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
FilterWithNamespace
function. Based on PR Improve trust bundle propagation #7665 all usage of the func was removedPre-review Checklist
Release Note
Docs