Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JobSink execution mode variable to K_EXECUTION_MODE #8350

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

pierDipi
Copy link
Member

Align to K_SINK.

Align to `K_SINK`.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2024
@knative-prow knative-prow bot requested review from creydr and matzew November 26, 2024 19:09
@creydr
Copy link
Member

creydr commented Nov 27, 2024

@pierDipi can you adjust the tests? e.g.

=== RUN   TestReconcile/Successful_reconciliation
    jobsink_test.go:236: Unexpected create (-want, +got):
          &v1.Job{
          	TypeMeta:   {},
          	ObjectMeta: {Name: "test-jobSinkzdfkp", Namespace: "test-namespace"},
          	Spec: v1.JobSpec{
          		... // 8 identical fields
          		Selector:       nil,
          		ManualSelector: nil,
          		Template: v1.PodTemplateSpec{
          			ObjectMeta: {},
          			Spec: v1.PodSpec{
          				Volumes:        nil,
          				InitContainers: nil,
          				Containers: []v1.Container{
          					{
          						... // 5 identical fields
          						Ports:   nil,
          						EnvFrom: nil,
          						Env: []v1.EnvVar{
          							{Name: "KNATIVE_EXECUTION_MODE", Value: "batch"},
        + 							{Name: "K_EXECUTION_MODE", Value: "batch"},
          						},
          						Resources:    {},
          						ResizePolicy: nil,
          						... // 14 identical fields
          					},
          				},
          				EphemeralContainers: nil,
          				RestartPolicy:       "",
          				... // 34 identical fields
          			},
          		},
          		TTLSecondsAfterFinished: nil,
          		CompletionMode:          nil,
          		... // 3 identical fields
          	},
          	Status: {},
          }
--- FAIL: TestReconcile/Successful_reconciliation (0.41s)

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@matzew
Copy link
Member

matzew commented Nov 27, 2024

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.27%. Comparing base (65da6fc) to head (e270746).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8350   +/-   ##
=======================================
  Coverage   64.27%   64.27%           
=======================================
  Files         390      390           
  Lines       23279    23279           
=======================================
  Hits        14963    14963           
  Misses       7522     7522           
  Partials      794      794           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2024
@pierDipi pierDipi requested a review from matzew November 28, 2024 08:12
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
Copy link

knative-prow bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [creydr,matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 545c14c into knative:main Nov 28, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants