-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change JobSink execution mode variable to K_EXECUTION_MODE
#8350
Change JobSink execution mode variable to K_EXECUTION_MODE
#8350
Conversation
Align to `K_SINK`. Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi can you adjust the tests? e.g.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8350 +/- ##
=======================================
Coverage 64.27% 64.27%
=======================================
Files 390 390
Lines 23279 23279
=======================================
Hits 14963 14963
Misses 7522 7522
Partials 794 794 ☔ View full report in Codecov by Sentry. |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Align to
K_SINK
.