Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing common integration helper and change package name #8327

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Introducing common integration helper and change package name #8327

merged 3 commits into from
Nov 19, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 13, 2024

Proposed Changes

  • as per title

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot requested review from aliok and Cali0707 November 13, 2024 16:06
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2024
@matzew
Copy link
Member Author

matzew commented Nov 13, 2024

/hold
DO NOT merge, need to be merged after otther PRs...

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.15385% with 84 lines in your changes missing coverage. Please review.

Project coverage is 64.53%. Comparing base (201e096) to head (58e8547).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/integration/source/resources/containersource.go 46.91% 43 Missing ⚠️
pkg/reconciler/integration/helper.go 45.33% 36 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8327      +/-   ##
==========================================
- Coverage   64.58%   64.53%   -0.05%     
==========================================
  Files         374      375       +1     
  Lines       22666    22666              
==========================================
- Hits        14639    14628      -11     
- Misses       7260     7271      +11     
  Partials      767      767

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@pierDipi
Copy link
Member

@matzew there are a few linting errors

@matzew matzew force-pushed the api_with_custom_struct_tags_versioned_common_integration_helper branch from acc2146 to 85b0c36 Compare November 19, 2024 10:46
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 19, 2024
@matzew
Copy link
Member Author

matzew commented Nov 19, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@matzew
Copy link
Member Author

matzew commented Nov 19, 2024

@pierDipi will look at linters. just rebased

@matzew matzew force-pushed the api_with_custom_struct_tags_versioned_common_integration_helper branch 2 times, most recently from 3c5aa78 to b91b164 Compare November 19, 2024 12:44
@matzew
create new integration/source folder and factor common code into help…
013765f 
…er.go

Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
💄 improve formatting...
ed13788 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
fixing import
58e8547 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the api_with_custom_struct_tags_versioned_common_integration_helper branch from b91b164 to 58e8547 Compare November 19, 2024 15:07
pierDipi
pierDipi approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ebe99e6 into knative:main Nov 19, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@aliok aliok Awaiting requested review from aliok

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @pierDipi