Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Integration sink and source: all together #8254

Closed
wants to merge 19 commits into from
Closed

WIP: Integration sink and source: all together #8254

wants to merge 19 commits into from

Conversation

matzew
Copy link
Member

@matzew matzew commented Oct 14, 2024

In progress (contains bits from closed #8239 ) and is layered on-top of #8238

/hold

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Oct 14, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from aliok and evankanderson October 14, 2024 12:57
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.01942% with 519 lines in your changes missing coverage. Please review.

Project coverage is 64.82%. Comparing base (6aa49dc) to head (7ea017f).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...iler/integration/sink/resources/container_image.go 0.00% 101 Missing ⚠️
pkg/reconciler/integration/sink/integrationsink.go 0.00% 98 Missing ⚠️
...er/integration/source/resources/containersource.go 0.00% 69 Missing ⚠️
pkg/reconciler/integration/helper.go 0.00% 59 Missing ⚠️
pkg/reconciler/integration/source/controller.go 0.00% 43 Missing ⚠️
pkg/reconciler/integration/sink/controller.go 0.00% 36 Missing ⚠️
...reconciler/integration/source/integrationsource.go 0.00% 30 Missing ⚠️
.../apis/sinks/v1alpha1/integration_sink_lifecycle.go 15.38% 22 Missing ⚠️
pkg/apis/sources/v1alpha1/integration_lifecycle.go 57.57% 14 Missing ⚠️
pkg/apis/sources/v1alpha1/register.go 0.00% 11 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8254      +/-   ##
==========================================
- Coverage   66.47%   64.82%   -1.65%     
==========================================
  Files         371      392      +21     
  Lines       18318    18936     +618     
==========================================
+ Hits        12176    12275      +99     
- Misses       5351     5865     +514     
- Partials      791      796       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew and others added 19 commits October 16, 2024 09:27
@matzew
Add initial raw API types and controller/reconciler. Levering interna…
9e15cc1 
…lly the container source for the handling of the kamelet workloads. the logic for applying the env-vars is a bit verbose, but can be improved.

Tests/lifeccyle and some other improvements are still missing. but this works.

Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
adding reflection to make the mapping less verbose, and more flexible…
5a433d7 
… to extend...

Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Add DDB Streams
05b37eb 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
polish and add minimal tests
a71a652 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew @pierDipi
Update pkg/apis/sources/v1alpha1/integration_lifecycle.go
1169796 
Co-authored-by: Pierangelo Di Pilato <[email protected]>
@matzew @pierDipi
Update pkg/apis/sources/v1alpha1/integration_lifecycle.go
ce209c8 
Co-authored-by: Pierangelo Di Pilato <[email protected]>
@matzew
Fix compiler warnings
bfcaf02 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
use other image coordinates
e114ee5 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
first test for source
1d4cc75 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Adding initial rekt test
96df997 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
First Sink
91c0828 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Updates on sink
687be52 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
starting common types for source
6d0b777 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
starting common types for sink
6be04c4 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
some code share and refactorings
ebbcba6 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
some fixes
8c5ecf9 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
use other image coordinates
c21a9a5 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Align sources w/ common API
ad4a9d2 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Add missing api and tests for sink and run codegen
7ea017f 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the integration_sink_and_source_all branch from 4f516d8 to 7ea017f Compare October 16, 2024 09:05
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member Author

matzew commented Nov 5, 2024

/close
repaced by #8304

@knative-prow knative-prow bot closed this Nov 5, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 5, 2024

@matzew: Closed this PR.

In response to this:

/close
repaced by #8304

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok Awaiting requested review from aliok

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @knative-prow-robot