-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove assumption on default namespace for EventType reference #7724
Remove assumption on default namespace for EventType reference #7724
Conversation
Signed-off-by: Pierangelo Di Pilato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for fixing my bug @pierDipi :)
/cherry-pick release-1.13 |
@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.12 |
@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi could you fix the two unit tests that are failing? It looks like they're expecting the namespace to be unset |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Pushed, GH is experiencing issues https://www.githubstatus.com/ so it might be slow to update and run CI |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7724 +/- ##
==========================================
- Coverage 69.06% 69.04% -0.02%
==========================================
Files 338 338
Lines 19351 19350 -1
==========================================
- Hits 13364 13360 -4
- Misses 5326 5328 +2
- Partials 661 662 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Calum Murray <[email protected]>
Co-authored-by: Calum Murray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Cali0707: new pull request created: #7725 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Cali0707: #7724 failed to apply on top of branch "release-1.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ve#7724) * Remove assumption on default namespace for EventType reference Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add and fix tests Signed-off-by: Pierangelo Di Pilato <[email protected]> * Update pkg/reconciler/source/duck/duck_test.go Co-authored-by: Calum Murray <[email protected]> * Update pkg/reconciler/source/duck/duck_test.go Co-authored-by: Calum Murray <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]> Co-authored-by: Calum Murray <[email protected]>
…ve#7724) (#548) * Remove assumption on default namespace for EventType reference * Add and fix tests * Update pkg/reconciler/source/duck/duck_test.go * Update pkg/reconciler/source/duck/duck_test.go --------- Signed-off-by: Pierangelo Di Pilato <[email protected]> Co-authored-by: Calum Murray <[email protected]>
Related to discussions in #7245