-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC - Support auto generation of PingSource identity service account and expose in AuthStatus #7344
Conversation
Skipping CI for Draft Pull Request. |
/retest |
/retest-required |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7344 +/- ##
==========================================
- Coverage 76.87% 76.84% -0.03%
==========================================
Files 252 252
Lines 13822 13861 +39
==========================================
+ Hits 10625 10651 +26
- Misses 2667 2677 +10
- Partials 530 533 +3
☔ View full report in Codecov by Sentry. |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Leo6Leo
/lgtm
/hold
could you add release note in the description? Feel free to unhold afterwards
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/retest-required |
Fixes #7227
Proposed Changes
Pre-review Checklist
Steps to test
1. Create a sink and an PingSource
A hacky and easy way to do so is run a rekt test that will create both
PingSource
andSink
for you.You run it and terminate it when you see both components has been created.
2. Find the created test namespace, sink name, and ping source name
3. Describe the PingSource
And we can see that
Auth: nil
whenauthentication.oidc
is disabled.4. Enable the authentication.oidc
Modify the value of
authentication.oidc
toenabled
5. Describe the PingSource
You will see that
6. View the eventing-controller log
You can also view the eventing-controller log to see the reconciliation when the config map is changed.
Release Note
Docs