Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mt-broker-filter as the Audience of a Triggers Subscriptions Subscriber #7319

Conversation

creydr
Copy link
Member

@creydr creydr commented Sep 29, 2023

Fixes #7292

Proposed Changes

  • 🎁 Use mt-broker-filter as the Audience of a Triggers Subscriptions Subscriber (pointing to the broker-filter)

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2023
@knative-prow knative-prow bot requested review from aliok and matzew September 29, 2023 12:03
@creydr
Copy link
Member Author

creydr commented Sep 29, 2023

When I create a Trigger, I get the following Subscription:

apiVersion: messaging.knative.dev/v1
kind: Subscription
metadata:
  ...
  name: github-my-trigger-03d5dd38-9210-424c-b98c-32f8e0b0e7f6
  namespace: default
  ownerReferences:
  - apiVersion: eventing.knative.dev/v1
    blockOwnerDeletion: true
    controller: true
    kind: Trigger
    name: my-trigger
    uid: 03d5dd38-9210-424c-b98c-32f8e0b0e7f6
spec:
  channel:
    apiVersion: messaging.knative.dev/v1
    kind: InMemoryChannel
    name: github-kne-trigger
  delivery:
    backoffDelay: PT0.2S
    backoffPolicy: exponential
    retry: 10
  reply:
    ref:
      apiVersion: eventing.knative.dev/v1
      kind: Broker
      name: github
      namespace: default
  subscriber:
    audience: mt-broker-filter
    uri: http://broker-filter.knative-eventing.svc.cluster.local/triggers/default/my-trigger/03d5dd38-9210-424c-b98c-32f8e0b0e7f6
status:
  ...
  physicalSubscription:
    replyAudience: eventing.knative.dev/broker/default/github
    replyUri: http://broker-ingress.knative-eventing.svc.cluster.local/default/github
    subscriberAudience: mt-broker-filter
    subscriberUri: http://broker-filter.knative-eventing.svc.cluster.local/triggers/default/my-trigger/03d5dd38-9210-424c-b98c-32f8e0b0e7f6

/assign @pierDipi @vishal-chdhry

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6915382) 77.50% compared to head (2a373f2) 77.51%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7319   +/-   ##
=======================================
  Coverage   77.50%   77.51%           
=======================================
  Files         250      250           
  Lines       13566    13569    +3     
=======================================
+ Hits        10515    10518    +3     
  Misses       2525     2525           
  Partials      526      526           
Files Coverage Δ
pkg/reconciler/broker/trigger/trigger.go 83.96% <100.00%> (+0.18%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member Author

creydr commented Sep 29, 2023

/retest

@pierDipi pierDipi self-requested a review October 2, 2023 11:37
@creydr
Copy link
Member Author

creydr commented Oct 2, 2023

/cc @pierDipi

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d1c3f15 into knative:main Oct 3, 2023
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use mt-broker-filter audience for a Triggers Subscriptions as subscribers audience
3 participants