Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audience field in Destinations to CRDs #7318

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented Sep 29, 2023

Since knative/pkg#2796 we have the Audience in duckv1.Destination. This should be reflected in the CRDs too.

Proposed Changes

  • 🧹 Add Audience field Destinations in CRDs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2023
@creydr
Copy link
Member Author

creydr commented Sep 29, 2023

/assign @pierDipi @vishal-chdhry

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3dfc2ea) 77.54% compared to head (6ad70a8) 77.52%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7318      +/-   ##
==========================================
- Coverage   77.54%   77.52%   -0.03%     
==========================================
  Files         250      250              
  Lines       13529    13529              
==========================================
- Hits        10491    10488       -3     
- Misses       2514     2516       +2     
- Partials      524      525       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 6915382 into knative:main Sep 29, 2023
21 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants