Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Audience field in CRDs #7244

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Add Audience field in CRDs #7244

merged 1 commit into from
Sep 11, 2023

Conversation

xiangpingjiang
Copy link
Contributor

Fixes #7189

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Add Audience field in CRDs

Docs

@knative-prow knative-prow bot requested review from matzew and pierDipi September 8, 2023 09:30
@knative-prow
Copy link

knative-prow bot commented Sep 8, 2023

Welcome @xiangpingjiang! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 8, 2023

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vishal-chdhry vishal-chdhry requested a review from creydr September 8, 2023 09:36
@creydr
Copy link
Member

creydr commented Sep 8, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (b082850) 77.75% compared to head (4879d5a) 77.73%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7244      +/-   ##
==========================================
- Coverage   77.75%   77.73%   -0.03%     
==========================================
  Files         246      246              
  Lines       13284    13284              
==========================================
- Hits        10329    10326       -3     
- Misses       2433     2435       +2     
- Partials      522      523       +1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member

creydr commented Sep 8, 2023

/retest

@creydr
Copy link
Member

creydr commented Sep 8, 2023

/test upgrade-tests

@xiangpingjiang
Copy link
Contributor Author

/retest

Cali0707
Cali0707 reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @xiangpingjiang!

I left a small suggestion on how to make the description for the Audience field a bit clearer, but otherwise this looks good!!

config/channels/in-memory-channel/resources/in-memory-channel.yaml Outdated Show resolved Hide resolved
config/channels/in-memory-channel/resources/in-memory-channel.yaml Outdated Show resolved Hide resolved
config/core/resources/broker.yaml Outdated Show resolved Hide resolved
config/core/resources/channel.yaml Outdated Show resolved Hide resolved
config/core/resources/parallel.yaml Outdated Show resolved Hide resolved
config/core/resources/sequence.yaml Outdated Show resolved Hide resolved
config/core/resources/sequence.yaml Outdated Show resolved Hide resolved
@xiangpingjiang xiangpingjiang force-pushed the Add_Audience_field_in_CRDs branch from 7e24ebe to 4879d5a Compare September 9, 2023 01:15
@creydr
Copy link
Member

creydr commented Sep 11, 2023

/test upgrade-tests

creydr
creydr approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @xiangpingjiang

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@knative-prow knative-prow bot merged commit 7876f12 into knative:main Sep 11, 2023
23 of 28 checks passed
@xiangpingjiang xiangpingjiang deleted the Add_Audience_field_in_CRDs branch February 3, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgencur mgencur mgencur left review comments

@creydr creydr creydr approved these changes

@matzew matzew Awaiting requested review from matzew

@pierDipi pierDipi Awaiting requested review from pierDipi

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Audience field in CRDs
4 participants
@xiangpingjiang @creydr @mgencur @Cali0707