Filters created once

[Cali0707]

Fixes #7210

Proposed Changes

• Add filters map to make managing existing filters easy
• Update filters interface to include cleanup method (needed for optimizations)
• use the filters map with the events handler to remove the need to create filters on every use

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

New Event Filters are now only created once, rather than on each event

Docs

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Patch coverage: 51.68% and project coverage change: -0.31% ⚠️

Comparison is base (d547e2d) 77.87% compared to head (3010456) 77.57%.
Report is 30 commits behind head on main.

❗ Current head 3010456 differs from pull request most recent head d5f514e. Consider uploading reports for the commit d5f514e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7213      +/-   ##
==========================================
- Coverage   77.87%   77.57%   -0.31%     
==========================================
  Files         246      249       +3     
  Lines       13214    13375     +161     
==========================================
+ Hits        10290    10375      +85     
- Misses       2402     2474      +72     
- Partials      522      526       +4     

Files Changed	Coverage Δ
pkg/eventfilter/attributes/filter.go	92.30% <0.00%> (-1.81%)	⬇️
pkg/eventfilter/subscriptionsapi/all_filter.go	92.30% <0.00%> (-7.70%)	⬇️
pkg/eventfilter/subscriptionsapi/any_filter.go	92.30% <0.00%> (-7.70%)	⬇️
pkg/eventfilter/subscriptionsapi/cesql_filter.go	87.09% <0.00%> (-2.91%)	⬇️
pkg/eventfilter/subscriptionsapi/exact_filter.go	54.54% <0.00%> (-2.60%)	⬇️
pkg/eventfilter/subscriptionsapi/not_filter.go	86.66% <0.00%> (-6.20%)	⬇️
pkg/eventfilter/subscriptionsapi/suffix_filter.go	66.66% <0.00%> (-2.30%)	⬇️
pkg/broker/filter/filter_handler.go	67.16% <37.50%> (-3.71%)	⬇️
pkg/eventfilter/subscriptionsapi/no_filter.go	40.00% <40.00%> (ø)
pkg/eventfilter/subscriptionsapi/filters_map.go	89.28% <89.28%> (ø)
... and 1 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cali0707]

/cc @pierDipi

[Cali0707]

/hold
Looks like the new rekt tests for filters are now failing, going to look into it...

[Cali0707]

/retest

[Cali0707]

@pierDipi @matzew @creydr it looks like there was an existing bug in the type assertions in the NewHandler function. I fixed it here: 1aa6e60. Should I backport this fix to any releases?

[Cali0707]

Other experimental tests are currently failing, but it looks like all of the new trigger filters tests are passing (they also pass for me locally) so I am going to unhold this.
/unhold
TestMTChannelBrokerAnyTriggerFilters.txt
TestMTChannelBrokerNewTriggerFilters.txt

[Cali0707]

/cc @matzew

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierDipi]

nit: there are some style issues

[Cali0707]

/hold
I'll fix the style issues :)

[Cali0707]

/unhold
/cc @pierDipi

[Leo6Leo]

/lgtm
For the latest commit!