[WIP] Add reconciler test for EventType references

[Leo6Leo]

Fixes #7031

Proposed Changes

Add reconciler test for EventType references

• A test showing an EventType reconciling properly with a Broker reference
• A test showing an EventType reconciling properly with a Channel reference

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Docs

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Leo6Leo
Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Leo6Leo]

Write down some initial attempt on this ticket. Am I on the right track? If yes, my question would be: how can we specify the eventType for a event here?

@creydr @pierDipi

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25400fb) 77.73% compared to head (560a7f2) 77.93%.
Report is 145 commits behind head on main.

❗ Current head 560a7f2 differs from pull request most recent head 9a81be4. Consider uploading reports for the commit 9a81be4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7114      +/-   ##
==========================================
+ Coverage   77.73%   77.93%   +0.20%     
==========================================
  Files         246      248       +2     
  Lines       13284    13315      +31     
==========================================
+ Hits        10326    10377      +51     
+ Misses       2435     2405      -30     
- Partials      523      533      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Leo6Leo]

Question: I added the new module eventtype in rekt. How should I import the module here?

Please lmk if this is not the right way to approach this ticket.

/cc @matzew @pierDipi @creydr

[creydr]

Seems you're using an incorrect import path. The knative modules are all under knative.dev/<repo>/... (no matter if it is a knative-sandbox project or not). So in this case it would be "knative.dev/eventing/test/rekt/features/eventtype"

[creydr]

Regarding the approach: In the test files (under test/rekt//_test.go), we usually setup only the environment and call the feature test (as you have done). In the feature test (test/rekt/features/) we have the according test implementation.

[Leo6Leo]

I tried that before. If I use knative.dev/eventing/test/rekt/features/eventtype, it will throw this error

test/rekt/eventtype_test.go:47:32: undefined: eventtype.eventTypeWithBrokerAsReference

Does importing the packages that starting with knative.dev/*** will actually download the latest knative package from the source? Because this eventTypeWithBrokerAsReference is a new function that I added in this PR, it hasn't been merged into the main branch. @creydr

[creydr]

It's probably, because you have to make eventTypeWithBrokerAsReference public

[Leo6Leo]

/hold
Unhold until #7166 #7180 are merged

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

[Leo6Leo]

/remove-lifecycle stale

[Leo6Leo]

Close as this PR wrong