Autoscaler considers reserved and pending replicas

[pierDipi]

Fixes #6733

• Make autoscaler leader aware
• Add grace period for scaling down

Signed-off-by: Pierangelo Di Pilato [email protected]

[codecov]

Codecov Report

Patch coverage: 51.12% and project coverage change: -0.24% ⚠️

Comparison is base (dd68bd3) 77.89% compared to head (c85b9ad) 77.65%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7027      +/-   ##
==========================================
- Coverage   77.89%   77.65%   -0.24%     
==========================================
  Files         246      246              
  Lines       13214    13301      +87     
==========================================
+ Hits        10293    10329      +36     
- Misses       2400     2450      +50     
- Partials      521      522       +1     

Files Changed	Coverage Δ
pkg/scheduler/statefulset/scheduler.go	72.43% <10.81%> (-4.84%)	⬇️
pkg/scheduler/state/state.go	82.31% <65.71%> (-2.22%)	⬇️
pkg/scheduler/statefulset/autoscaler.go	76.99% <67.21%> (-0.66%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matzew]

the naming is a bit inconsistent, but we can fix that afterwards (e.g. PendingVReplica...)

[matzew]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierDipi]

/cherry-pick release-1.11

[pierDipi]

/cherry-pick release-1.10

[knative-prow-robot]

@pierDipi: new pull request created: #7216

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@pierDipi: #7027 failed to apply on top of branch "release-1.10":

Applying: Autoscaler considers reserved and pending replicas
Applying: Format / lint fix
Applying: Simplify MAXFILLUP logic to get the expected replicas
Using index info to reconstruct a base tree...
M	pkg/scheduler/statefulset/autoscaler.go
M	pkg/scheduler/statefulset/scheduler.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/scheduler/statefulset/scheduler.go
CONFLICT (content): Merge conflict in pkg/scheduler/statefulset/scheduler.go
Auto-merging pkg/scheduler/statefulset/autoscaler.go
CONFLICT (content): Merge conflict in pkg/scheduler/statefulset/autoscaler.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Simplify MAXFILLUP logic to get the expected replicas
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.