Add marker for Trigger condition to mark OIDCIdentity condition as no…

…t supported
knative · Sep 28, 2023 · 94941b2 · 94941b2
1 parent 3dfc2ea
commit 94941b2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/pkg/apis/eventing/v1/trigger_lifecycle.go b/pkg/apis/eventing/v1/trigger_lifecycle.go
@@ -17,8 +17,11 @@ limitations under the License.
 package v1
 
 import (
+	"fmt"
+
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/runtime/schema"
+	"knative.dev/eventing/pkg/apis/feature"
 	"knative.dev/pkg/apis"
 	duckv1 "knative.dev/pkg/apis/duck/v1"
 )
@@ -217,3 +220,8 @@ func (ts *TriggerStatus) MarkOIDCIdentityCreatedFailed(reason, messageFormat str
 func (ts *TriggerStatus) MarkOIDCIdentityCreatedUnknown(reason, messageFormat string, messageA ...interface{}) {
 	triggerCondSet.Manage(ts).MarkUnknown(TriggerConditionOIDCIdentityCreated, reason, messageFormat, messageA...)
 }
+
+func (ts *TriggerStatus) MarkOIDCIdentityCreatedNotSupported() {
+	// in case the OIDC feature is not supported, we mark the conditon as true, to not mark the Trigger unready.
+	triggerCondSet.Manage(ts).MarkTrueWithReason(TriggerConditionOIDCIdentityCreated, fmt.Sprintf("%s feature not yet supported for this Broker class", feature.OIDCAuthentication), "")
+}
diff --git a/pkg/reconciler/testing/v1/trigger.go b/pkg/reconciler/testing/v1/trigger.go
@@ -281,6 +281,12 @@ func WithTriggerOIDCIdentityCreatedFailed(reason, message string) TriggerOption
 	}
 }
 
+func WithTriggerOIDCIdentityCreatedNotSupported() TriggerOption {
+	return func(t *v1.Trigger) {
+		t.Status.MarkOIDCIdentityCreatedNotSupported()
+	}
+}
+
 func WithTriggerOIDCServiceAccountName(name string) TriggerOption {
 	return func(t *v1.Trigger) {
 		if t.Status.Auth == nil {