Skip to content

Introduce new EventTypeDefinition API/CRD #5048

Introduce new EventTypeDefinition API/CRD

Introduce new EventTypeDefinition API/CRD #5048

Triggered via pull request September 7, 2023 09:06
Status Failure
Total duration 6m 19s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

knative-style.yaml

on: pull_request
style  /  changes
4s
style / changes
style  /  ...  /  Auto-format and Check
25s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
5m 53s
style / Golang / Lint
style  /  ...  /  Do Not Submit
5s
style / Golang / Do Not Submit
style  /  ...  /  shell
8s
style / suggester / shell
style  /  ...  /  yaml
19s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

15 errors and 10 warnings
style / Golang / Boilerplate Check (go): pkg/apis/eventing/v1alpha1/doc.go#L8
[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/apis/eventing/v1alpha1/doc.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"
style / Golang / Boilerplate Check (go): pkg/apis/eventing/v1alpha1/eventtypedefinition_defaults.go#L1
[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/apis/eventing/v1alpha1/eventtypedefinition_defaults.go:1: missing boilerplate: /* Copyright 2023 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */
style / Golang / Boilerplate Check (go): pkg/apis/eventing/v1alpha1/eventtypedefinition_lifecycle.go#L1
[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/apis/eventing/v1alpha1/eventtypedefinition_lifecycle.go:1: missing boilerplate: /* Copyright 2023 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */
style / Golang / Boilerplate Check (go): pkg/apis/eventing/v1alpha1/eventtypedefinition_types.go#L8
[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/apis/eventing/v1alpha1/eventtypedefinition_types.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"
style / Golang / Boilerplate Check (go): pkg/apis/eventing/v1alpha1/eventtypedefinition_validation.go#L1
[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/apis/eventing/v1alpha1/eventtypedefinition_validation.go:1: missing boilerplate: /* Copyright 2023 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */
style / Golang / Boilerplate Check (go): pkg/apis/eventing/v1alpha1/register.go#L8
[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/apis/eventing/v1alpha1/register.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"
style / Golang / Boilerplate Check (go): pkg/reconciler/eventtypedefinition/controller.go#L8
[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/reconciler/eventtypedefinition/controller.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"
style / Golang / Boilerplate Check (go): pkg/reconciler/eventtypedefinition/eventtypedefinition.go#L8
[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/reconciler/eventtypedefinition/eventtypedefinition.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"
style / Golang / Boilerplate Check (go)
Process completed with exit code 1.
style / Golang / Auto-format and Check: cmd/webhook/main.go#L1
Please run goimports. diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go index a2b877d..8dac3a2 100644 --- a/cmd/webhook/main.go +++ b/cmd/webhook/main.go @@ -18,9 +18,10 @@ package main import ( "context" - eventingv1alpha1 "knative.dev/eventing/pkg/apis/eventing/v1alpha1" "os" + eventingv1alpha1 "knative.dev/eventing/pkg/apis/eventing/v1alpha1" + "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/kubernetes/scheme"
style / Golang / Auto-format and Check: pkg/apis/eventing/v1alpha1/eventtypedefinition_validation.go#L1
Please run goimports. diff --git a/pkg/apis/eventing/v1alpha1/eventtypedefinition_validation.go b/pkg/apis/eventing/v1alpha1/eventtypedefinition_validation.go index a9a5052..c1506a1 100644 --- a/pkg/apis/eventing/v1alpha1/eventtypedefinition_validation.go +++ b/pkg/apis/eventing/v1alpha1/eventtypedefinition_validation.go @@ -2,6 +2,7 @@ package v1alpha1 import ( "context" + "knative.dev/pkg/apis" )
style / Golang / Auto-format and Check: pkg/reconciler/eventtypedefinition/controller.go#L1
Please run goimports. diff --git a/pkg/reconciler/eventtypedefinition/controller.go b/pkg/reconciler/eventtypedefinition/controller.go index a174e65..a663425 100644 --- a/pkg/reconciler/eventtypedefinition/controller.go +++ b/pkg/reconciler/eventtypedefinition/controller.go @@ -18,6 +18,7 @@ package eventtypedefinition import ( "context" + "knative.dev/pkg/configmap" "knative.dev/pkg/controller"
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Lint: config/core/resources/eventtypedefinition.yaml#L55
[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: config/core/resources/eventtypedefinition.yaml:55: Missing newline
style / Golang / Lint
Process completed with exit code 1.
style / Golang / Boilerplate Check (go)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
style / Golang / Boilerplate Check (go)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Boilerplate Check (sh)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
style / Golang / Boilerplate Check (sh)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/