Skip to content

JobSink: Inject a KNATIVE_EXECUTION_MODE environment variable with value batch #6931

JobSink: Inject a KNATIVE_EXECUTION_MODE environment variable with value batch

JobSink: Inject a KNATIVE_EXECUTION_MODE environment variable with value batch #6931

Triggered via pull request November 25, 2024 15:15
Status Failure
Total duration 3m 47s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
2s
style / changes
style  /  ...  /  Auto-format and Check
17s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
3m 19s
style / Golang / Lint
style  /  ...  /  Do Not Submit
9s
style / Golang / Do Not Submit
style  /  ...  /  shell
0s
style / suggester / shell
style  /  ...  /  yaml
0s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 4 warnings
style / Golang / Auto-format and Check: pkg/apis/sinks/v1alpha1/job_sink_defaults_test.go#L1
Please run goimports. diff --git a/pkg/apis/sinks/v1alpha1/job_sink_defaults_test.go b/pkg/apis/sinks/v1alpha1/job_sink_defaults_test.go index 766ab45..5f693c0 100644 --- a/pkg/apis/sinks/v1alpha1/job_sink_defaults_test.go +++ b/pkg/apis/sinks/v1alpha1/job_sink_defaults_test.go @@ -34,21 +34,21 @@ func TestSetDefaults(t *testing.T) { initial: JobSink{ Spec: JobSinkSpec{ Job: &batchv1.Job{ - Spec: batchv1.JobSpec{ + Spec: batchv1.JobSpec{ Template: corev1.PodTemplateSpec{ - Spec: corev1.PodSpec{ + Spec: corev1.PodSpec{ Containers: []corev1.Container{ { - Name: "cnt", - Image: "img", + Name: "cnt", + Image: "img", }, { - Name: "cnt2", - Image: "img2", + Name: "cnt2", + Image: "img2", }, { - Name: "cnt3", - Image: "img3", + Name: "cnt3", + Image: "img3", Env: []corev1.EnvVar{ {Name: "KNATIVE_EXECUTION_MODE", Value: "something"}, }, @@ -56,12 +56,12 @@ func TestSetDefaults(t *testing.T) { }, InitContainers: []corev1.Container{ { - Name: "cnt", - Image: "img", + Name: "cnt", + Image: "img", }, { - Name: "cnt-ini2", - Image: "img-ini2", + Name: "cnt-ini2", + Image: "img-ini2", Env: []corev1.EnvVar{ {Name: "KNATIVE_EXECUTION_MODE", Value: "something"}, }, @@ -76,20 +76,20 @@ func TestSetDefaults(t *testing.T) { expected: JobSink{ Spec: JobSinkSpec{ Job: &batchv1.Job{ - Spec: batchv1.JobSpec{ + Spec: batchv1.JobSpec{ Template: corev1.PodTemplateSpec{ - Spec: corev1.PodSpec{ + Spec: corev1.PodSpec{ InitContainers: []corev1.Container{ { - Name: "cnt", - Image: "img", + Name: "cnt", + Image: "img", Env: []corev1.EnvVar{ {Name: "KNATIVE_EXECUTION_MODE", Value: "batch"}, }, }, { - Name: "cnt-ini2", - Image: "img-ini2", + Name: "cnt-ini2", + Image: "img-ini2", Env: []corev1.EnvVar{ {Name: "KNATIVE_EXECUTION_MODE", Value: "something"}, }, @@ -97,22 +97,22 @@ func TestSetDefaults(t *testing.T) { }, Containers: []corev1.Container{ { - Name: "cnt", - Image: "img", + Name: "cnt", + Image: "img", Env: []corev1.EnvVar{ {Name: "KNATIVE_EXECUTION_MODE", Value: "batch"}, }, }, { - Name: "cnt2", - Image: "img2", + Name: "cnt2", + Image: "img2", Env: []corev1.EnvVar{ {Name: "KNATIVE_EXECUTION_MODE", Value: "batch"}, }, }, { - Name: "cnt3", - Image: "img3", + Name: "cnt3", + Image: "img3", Env: []corev1.EnvVar{ {Name: "KNATIVE_EXECUTION_MODE", Value: "something"}, },
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum