Skip to content

[release-1.16] fix: rename job-sink to job_sink #6924

[release-1.16] fix: rename job-sink to job_sink

[release-1.16] fix: rename job-sink to job_sink #6924

Triggered via pull request November 21, 2024 15:23
Status Failure
Total duration 3m 42s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
2s
style / changes
style  /  ...  /  Auto-format and Check
23s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
3m 22s
style / Golang / Lint
style  /  ...  /  Do Not Submit
7s
style / Golang / Do Not Submit
style  /  ...  /  shell
0s
style / suggester / shell
style  /  ...  /  yaml
0s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 4 warnings
style / Golang / Auto-format and Check: pkg/scheduler/statefulset/scheduler_test.go#L1
Please run goimports. diff --git a/pkg/scheduler/statefulset/scheduler_test.go b/pkg/scheduler/statefulset/scheduler_test.go index 8bb5c5a..8bb54fb 100644 --- a/pkg/scheduler/statefulset/scheduler_test.go +++ b/pkg/scheduler/statefulset/scheduler_test.go @@ -643,18 +643,18 @@ func TestStatefulsetScheduler(t *testing.T) { err: controller.NewRequeueAfter(5 * time.Second), }, { - name: "Unschedulable pod", - vreplicas: 20, - replicas: int32(1), - capacity: 20, + name: "Unschedulable pod", + vreplicas: 20, + replicas: int32(1), + capacity: 20, unschedulablePods: sets.New[int32](0), - err: controller.NewRequeueAfter(5 * time.Second), + err: controller.NewRequeueAfter(5 * time.Second), }, { - name: "Unschedulable pod, with reserved and some space", - vreplicas: 20, - replicas: int32(2), - capacity: 20, + name: "Unschedulable pod, with reserved and some space", + vreplicas: 20, + replicas: int32(2), + capacity: 20, expected: []duckv1alpha1.Placement{ {PodName: "statefulset-name-0", VReplicas: 2}, }, @@ -672,13 +672,13 @@ func TestStatefulsetScheduler(t *testing.T) { }, }, unschedulablePods: sets.New[int32](1), - err: controller.NewRequeueAfter(5 * time.Second), + err: controller.NewRequeueAfter(5 * time.Second), }, { - name: "Unschedulable middle pod, with reserved and some space", - vreplicas: 20, - replicas: int32(3), - capacity: 20, + name: "Unschedulable middle pod, with reserved and some space", + vreplicas: 20, + replicas: int32(3), + capacity: 20, expected: []duckv1alpha1.Placement{ {PodName: "statefulset-name-0", VReplicas: 2}, {PodName: "statefulset-name-2", VReplicas: 18},
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum