[release-1.15] JobSink: Delete secrets associated with jobs when jobs are deleted #6908
Annotations
3 errors and 1 warning
Verify goimports:
pkg/scheduler/statefulset/scheduler_test.go#L1
Please run goimports.
diff --git a/pkg/scheduler/statefulset/scheduler_test.go b/pkg/scheduler/statefulset/scheduler_test.go
index 8bb5c5a..8bb54fb 100644
--- a/pkg/scheduler/statefulset/scheduler_test.go
+++ b/pkg/scheduler/statefulset/scheduler_test.go
@@ -643,18 +643,18 @@ func TestStatefulsetScheduler(t *testing.T) {
err: controller.NewRequeueAfter(5 * time.Second),
},
{
- name: "Unschedulable pod",
- vreplicas: 20,
- replicas: int32(1),
- capacity: 20,
+ name: "Unschedulable pod",
+ vreplicas: 20,
+ replicas: int32(1),
+ capacity: 20,
unschedulablePods: sets.New[int32](0),
- err: controller.NewRequeueAfter(5 * time.Second),
+ err: controller.NewRequeueAfter(5 * time.Second),
},
{
- name: "Unschedulable pod, with reserved and some space",
- vreplicas: 20,
- replicas: int32(2),
- capacity: 20,
+ name: "Unschedulable pod, with reserved and some space",
+ vreplicas: 20,
+ replicas: int32(2),
+ capacity: 20,
expected: []duckv1alpha1.Placement{
{PodName: "statefulset-name-0", VReplicas: 2},
},
@@ -672,13 +672,13 @@ func TestStatefulsetScheduler(t *testing.T) {
},
},
unschedulablePods: sets.New[int32](1),
- err: controller.NewRequeueAfter(5 * time.Second),
+ err: controller.NewRequeueAfter(5 * time.Second),
},
{
- name: "Unschedulable middle pod, with reserved and some space",
- vreplicas: 20,
- replicas: int32(3),
- capacity: 20,
+ name: "Unschedulable middle pod, with reserved and some space",
+ vreplicas: 20,
+ replicas: int32(3),
+ capacity: 20,
expected: []duckv1alpha1.Placement{
{PodName: "statefulset-name-0", VReplicas: 2},
{PodName: "statefulset-name-2", VReplicas: 18},
|
Verify goimports:
test/rekt/job_sink_test.go#L1
Please run goimports.
diff --git a/test/rekt/job_sink_test.go b/test/rekt/job_sink_test.go
index f3eada1..402698c 100644
--- a/test/rekt/job_sink_test.go
+++ b/test/rekt/job_sink_test.go
@@ -25,6 +25,7 @@ import (
"knative.dev/pkg/system"
"knative.dev/reconciler-test/pkg/environment"
"knative.dev/reconciler-test/pkg/eventshub"
+ "knative.dev/reconciler-test/pkg/feature"
"knative.dev/reconciler-test/pkg/k8s"
"knative.dev/reconciler-test/pkg/knative"
|
Verify goimports
Process completed with exit code 1.
|
Set up Go
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
Loading