-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WG leads to docs approvers #5968
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pierangelo Di Pilato <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @knative/technical-oversight-committee |
/assign @knative/technical-oversight-committee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me!
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the issue is approving page changes, would it make sense to add the working group leads as owners on the config directory rather than for all of docs? Though given that there's no docs team right now, perhaps it's better to have more folks able to approve for the whole repo?
Yeah - let's subdivide the owners to the various sections |
@pierDipi can you update the PR? |
This Pull Request is stale because it has been open for 90 days with |
/remove-lifecycle stale |
@pierDipi gentle ping |
Every time there is a new page added, I cannot approve PRs (example #5916), so I'm adding WG leads to the top-level directory approvers