Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump maven to latest version 3.9.9 #4096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 12, 2024

./mvnw -N wrapper:wrapper -Dmaven=3.9.9

Also remove editorconfig as it's unused

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot added area/data-plane size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 12, 2024
@knative-prow knative-prow bot requested review from aliok and matzew September 12, 2024 14:29
Copy link

knative-prow bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.55%. Comparing base (76e67cd) to head (13aa7b9).
Report is 27 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4096   +/-   ##
=======================================
  Coverage   48.55%   48.55%           
=======================================
  Files         244      244           
  Lines       14825    14825           
=======================================
  Hits         7199     7199           
  Misses       6912     6912           
  Partials      714      714           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/retest

@pierDipi
Copy link
Member Author

/cc @creydr @matzew

@knative-prow knative-prow bot requested a review from creydr September 13, 2024 16:20
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
@matzew
Copy link
Contributor

matzew commented Oct 9, 2024

/retest

@matzew
Copy link
Contributor

matzew commented Oct 10, 2024

/retest-required

@matzew
Copy link
Contributor

matzew commented Oct 28, 2024

/test reconciler-tests-namespaced-broker

1 similar comment
@matzew
Copy link
Contributor

matzew commented Oct 28, 2024

/test reconciler-tests-namespaced-broker

Copy link

knative-prow bot commented Oct 28, 2024

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka-broker_main 13aa7b9 link unknown /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants