-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provision delivery format in contract #3987
base: main
Are you sure you want to change the base?
Provision delivery format in contract #3987
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3987 +/- ##
==========================================
- Coverage 48.33% 48.27% -0.07%
==========================================
Files 244 244
Lines 14579 14600 +21
==========================================
+ Hits 7047 7048 +1
- Misses 6821 6840 +19
- Partials 711 712 +1 ☔ View full report in Codecov by Sentry. |
/test upgrade-tests |
Signed-off-by: Calum Murray <[email protected]>
57df63b
to
aa4efb2
Compare
@matzew I've rebased this to only have the relevant changes, can you recheck? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest |
/retest-required |
1 similar comment
/retest-required |
/test upgrade-tests |
New changes are detected. LGTM label has been removed. |
/cc @matzew While going through the data plane changes I realized I needed to essentially re-do the changes in this PR so since the data plane changes are isolated I added them here as well instead I'll add unit tests and an e2e test later, would you mind taking a look at the data plane code and letting me know if the approach I'm taking makes sense? |
Signed-off-by: Calum Murray <[email protected]>
d0a7395
to
6d2d475
Compare
/cc @pierDipi |
/retest |
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
/retest-required |
@Cali0707: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This Pull Request is stale because it has been open for 90 days with |
Fixes #3970
Proposed Changes
format
field to the egress config