-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to latest Quarkus 3.8.x and matching vertx #3929
base: main
Are you sure you want to change the base?
Bump to latest Quarkus 3.8.x and matching vertx #3929
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
==========================================
- Coverage 48.22% 48.20% -0.02%
==========================================
Files 246 246
Lines 14533 14533
==========================================
- Hits 7008 7006 -2
- Misses 6820 6821 +1
- Partials 705 706 +1 ☔ View full report in Codecov by Sentry. |
/retest |
1 similar comment
/retest |
3b8957b
to
c9ad915
Compare
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
c9ad915
to
a1f899f
Compare
/retest-required |
4 similar comments
/retest-required |
/retest-required |
/retest-required |
/retest-required |
a1f899f
to
cb9dc2c
Compare
/retest |
Signed-off-by: Matthias Wessendorf <[email protected]>
cb9dc2c
to
7a34e4f
Compare
@matzew: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -43,7 +43,7 @@ | |||
<spotless.plugin.version>2.38.0</spotless.plugin.version> | |||
|
|||
<!-- dependencies version --> | |||
<vertx.version>4.4.7</vertx.version> | |||
<vertx.version>4.5.7</vertx.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierDipi when I change this back to 4.4.7, the "trancing" unit test failure goes away.
However, the one inside Quarkus is based on 4.5.7
Looks like our vertx dependency is a bit unbalanced scope? I was thinking we work with that version from inside the Quarkus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, that is just opentelemetry
(and junit5
):
mvn dependency:tree | grep 4.4.7
[INFO] +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] | +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] | +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] | +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] | | +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
[INFO] | +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] | +- io.vertx:vertx-opentelemetry:jar:4.4.7:compile
[INFO] +- io.vertx:vertx-junit5:jar:4.4.7:test
Getting tracing unit test failure:
|
This Pull Request is stale because it has been open for 90 days with |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #
Proposed Changes
Release Note
Docs