-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added any filter benchmarks which mirror those in eventing core #3361
Added any filter benchmarks which mirror those in eventing core #3361
Conversation
Signed-off-by: Calum Murray <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3361 +/- ##
============================================
- Coverage 61.63% 61.61% -0.03%
+ Complexity 769 768 -1
============================================
Files 182 182
Lines 12333 12333
Branches 268 268
============================================
- Hits 7602 7599 -3
- Misses 4135 4137 +2
- Partials 596 597 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Calum Murray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Cali0707: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
e4a9113
into
knative-extensions:main
Fixes #3235
Proposed Changes