Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added any filter benchmarks which mirror those in eventing core #3361

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

Cali0707
Copy link
Member

Fixes #3235

Proposed Changes

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2023
@Cali0707
Copy link
Member Author

/cc @Leo6Leo @creydr

@knative-prow knative-prow bot requested review from creydr and Leo6Leo September 25, 2023 20:23
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #3361 (8e60c7f) into main (805aef4) will decrease coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3361      +/-   ##
============================================
- Coverage     61.63%   61.61%   -0.03%     
+ Complexity      769      768       -1     
============================================
  Files           182      182              
  Lines         12333    12333              
  Branches        268      268              
============================================
- Hits           7602     7599       -3     
- Misses         4135     4137       +2     
- Partials        596      597       +1     
Flag Coverage Δ
java-unittests 70.90% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 26, 2023

@Cali0707: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests-keda_eventing-kafka-broker_main 8e60c7f link false /test reconciler-tests-keda
reconciler-tests-loom_eventing-kafka-broker_main 8e60c7f link false /test reconciler-tests-loom
reconciler-tests-namespaced-broker-loom_eventing-kafka-broker_main 8e60c7f link false /test reconciler-tests-namespaced-broker-loom

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cali0707
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit e4a9113 into knative-extensions:main Sep 26, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Event Filtering: Benchmark Java Implementation of "Any" filter
2 participants