-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service and documentation for istio (mesh mode) #83
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: muscionig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @muscionig. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @skonto
I will open another issue for documenting Openshift ServiceMesh. |
|
||
### Install Prometheus and KEDA | ||
|
||
In `PERMISSIVE` mode (under the `knative-serving` namespace), clear-text traffic and encrypted traffic are both allowed, with the latter preferred by `istio` when properly configured. The following instructions will not enable Mutual TLS between `knative`, `keda` and `prometheus`. If running in `STRICT` mode, `istio` provides [documentation](https://istio.io/latest/docs/ops/integrations/prometheus/#tls-settings) on how to setup mTLS between "data" plane pods for `prometheus`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is useful to have the strict mode as well. I have an example here. I will create a PR with some more info so we can finalize content.
Btw did you test encrypted traffic with permissive mode and autoscaling?
closes #56
Changes
This PR adds documentation to run the
autoscaler-keda
extension withIstio
injection.@skonto I opened this on top of #81, that is why the set of changes is larger. Feel free to directly review only this PR.
Minor Changes
Istio
.istio
in mesh mode.prometheus
in its own namespace (to facilitate mTLS setup with the documentation provided byIstio
) and edits to theconfig-autoscaler-keda
configmap to scrape metric from a specific prometheus address.istio
:before scaling:
During scaling:
/kind documentation
/kind enhancement