This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
Add default name to form components #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, finally got the chance to go back to this one. Love it. Perfect approach. I will merge the "make everything uncontrolled" branch into this and put the higher-order component in all the relevant components, I think we’ll be good to go. |
xaviervia
changed the title
3 tasks
added 2 commits
November 11, 2016 15:49
|
Works now. @Nevon mind to review? |
xaviervia
changed the base branch from
master
to
make-uncontrolled-the-default
Nevon
commented
Nov 11, 2016
| @@ -0,0 +1,13 @@ | |||
| import seededRandom from 'seed-random' | |||
There was a problem hiding this comment.
This shouldn't be needed anymore, right, since you're using the higher-order-components package instead. Same for lib/uniqueComponentName.
|
And now the build is failing because there's an imprecise dependency of react. react-maskedinput seems to be importing a private module from react, which either no longer exists or has been moved. insin/react-maskedinput#76 |
Nevon
force-pushed
the
add-default-name-to-form-components
branch
from
c2b5190 to
53493ae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
So this is a first attempt at generating stable, unique names for form controls where the name is not specified as a prop.
I've only added it to the uncontrolled field at the moment, so to try it out, remove the
namefrom one of the examples where it is used. When the control re-renders, the name should stay the same, and the name should be unique.The general idea is that we concatenate the component name with a UUIDv4, which is seeded using a counter in the closure. This means that the uuid will very likely be re-used, but only with other components. There should never be a complete name collision due to the component name being different.