Feat : 내 커리어 활동 CRUD 기능 추가 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hyeonda02
commented
Jul 24, 2024
hyeonda02
commented
- 카테고리 , 활동 엔티티 추가
- 활동 생성 API 추가
- 활동 수정 API 추가
- 활동 삭제 API 추가
- 카테고리 , 연도 별 활동 조회 API 추가
tape4
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
exception을 핸들링하는 advice와 exception를 정의한 클래스를 common 패키지로 옮겨서 한눈에 관리하죠!
There was a problem hiding this comment.
넵 advice랑 exception 클래스만 common으로 옮기고 기존에 있던 exception 패키지는 지우면 되나요??
There was a problem hiding this comment.
넵 그렇게 하시고 테스트 통과만 확인하면 될것같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.