Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getBestPublicIp for all valid ips #1132

Merged
merged 5 commits into from
Oct 2, 2024

Add ip availability check in server start

95529d2
Select commit
Loading
Failed to load commit list.
Merged

Refactor getBestPublicIp for all valid ips #1132

Add ip availability check in server start
95529d2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 0s

41.42% (-0.02%) compared to bef3ec7

View this Pull Request on Codecov

41.42% (-0.02%) compared to bef3ec7

Details

Codecov Report

Attention: Patch coverage is 35.71429% with 36 lines in your changes missing coverage. Please review.

Project coverage is 41.42%. Comparing base (bef3ec7) to head (95529d2).

Files with missing lines Patch % Lines
src/server/internalServer.cpp 17.85% 12 Missing and 11 partials ⚠️
src/tools/networkTools.cpp 68.42% 1 Missing and 5 partials ⚠️
src/server.cpp 28.57% 3 Missing and 2 partials ⚠️
src/server/internalServer.h 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   41.43%   41.42%   -0.02%     
==========================================
  Files          59       59              
  Lines        4245     4268      +23     
  Branches     2323     2336      +13     
==========================================
+ Hits         1759     1768       +9     
- Misses        990      999       +9     
- Partials     1496     1501       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov