More conspicuous download button

[kelson42]

Fixes #1040
Fixes #1130

[veloman-yunkan]

@kelson42 Who is going to review this PR? I wanted to add you as a reviewer, but GitHub won't let me do it (likely, because you are the "author" of this PR).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.43%. Comparing base (bec80e8) to head (3cdc036).
Report is 45 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1094   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files          59       59           
  Lines        4245     4245           
  Branches     2323     2323           
=======================================
  Hits         1759     1759           
  Misses        990      990           
  Partials     1496     1496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kelson42]

@veloman-yunkan Please review and fix. The code is from @juuz0. I think the proposal of improvement is OK. I have only one small concern: the grey borders around the new blue button even if perfectly there, look inexistant which - at least to me - give the impression that the button is smaller than the box (1px left and 1px right). Do you have also this feeling?

[veloman-yunkan]

Please review and fix. The code is from @juuz0.

I know. I already modified @juuz0's changes, pushed the branch and was going to create a PR when GitHub told me that there is already a PR (this one) associated with that branch. It would be strange if I review my own PR.

I think the proposal of improvement is OK.

Which proposal of improvement do you mean?

I have only one small concern: the grey borders around the new blue button even if perfectly there, look inexistant which - at least to me - give the impression that the button is smaller than the box (1px left and 1px right). Do you have also this feeling?

It didn't catch my attention but after looking closely - yes, it looks like that.

[veloman-yunkan]

I have only one small concern: the grey borders around the new blue button even if perfectly there, look inexistant which - at least to me - give the impression that the button is smaller than the box (1px left and 1px right). Do you have also this feeling?

It didn't catch my attention but after looking closely - yes, it looks like that.

Fixed by changing the border color to that of the button itself.

[kelson42]

I have only one small concern: the grey borders around the new blue button even if perfectly there, look inexistant which - at least to me - give the impression that the button is smaller than the box (1px left and 1px right). Do you have also this feeling?

It didn't catch my attention but after looking closely - yes, it looks like that.

Fixed by changing the border color to that of the button itself.

Great, but now we have some kind of white framing appearing if highlighed.

[veloman-yunkan]

I have only one small concern: the grey borders around the new blue button even if perfectly there, look inexistant which - at least to me - give the impression that the button is smaller than the box (1px left and 1px right). Do you have also this feeling?

It didn't catch my attention but after looking closely - yes, it looks like that.

Fixed by changing the border color to that of the button itself.

Great, but now we have some kind of white framing appearing if highlighed.

There is no such effect under Firefox, but I confirm that I could observe it under Chromium.

[veloman-yunkan]

I have only one small concern: the grey borders around the new blue button even if perfectly there, look inexistant which - at least to me - give the impression that the button is smaller than the box (1px left and 1px right). Do you have also this feeling?

It didn't catch my attention but after looking closely - yes, it looks like that.

Fixed by changing the border color to that of the button itself.

Great, but now we have some kind of white framing appearing if highlighed.

There is no such effect under Firefox, but I confirm that I could observe it under Chromium.

Fixed in a different way. @kelson42 Please test again.

[veloman-yunkan]

@kelson42 Note that I didn't update the cacheid's. I will update them (and make the CI pass) while squashing the fixup commits once we are done with the visual appearance issues.

[kelson42]

@veloman-yunkan Thx! Good to merge then when commits are reorganised!

[veloman-yunkan]

@veloman-yunkan Thx! Good to merge then when commits are reorganised!

Done

[veloman-yunkan]

I discovered two bugs (#1129 and #1130). The latter one is actually introduced by this PR, so maybe I better fix it before this PR is merged.

[veloman-yunkan]

No-JS page contains a usability bug (#1130).

[kelson42]

@veloman-yunkan No absolutly sure about your approach/opinion, but to me #1130 should not be introduced by this PR (so fixed here).

[veloman-yunkan]

@veloman-yunkan No absolutly sure about your approach/opinion, but to me #1130 should not be introduced by this PR (so fixed here).

Done