Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to new api introduced in kiwix/libkiwix#991 #992

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Adapt to new api introduced in kiwix/libkiwix#991 #992

merged 2 commits into from
Oct 12, 2023

Conversation

mgautierfr
Copy link
Member

@mgautierfr mgautierfr commented Aug 23, 2023 •
edited
Loading

This is the following of kiwix/libkiwix#991

kiwix::Library must be handle through a shared_ptr and cannot be created directly on the stack.

@mgautierfr mgautierfr removed the request for review from veloman-yunkan October 6, 2023 09:50
@mgautierfr
Copy link
Member Author

This PR is needed as it fixes the CI which is broken since several days. I'm merging.
Please open a issue if you disagree with the code :)

@mgautierfr mgautierfr merged commit d721eea into main Oct 12, 2023
4 checks passed
@mgautierfr mgautierfr deleted the adapt_libkiwix_991 branch October 12, 2023 16:07
@kelson42 kelson42 mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juuz0 juuz0 Awaiting requested review from juuz0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgautierfr