Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in kiwix-desktop's source publishing step #787

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fixed a bug in kiwix-desktop's source publishing step #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d838cf
Fixed a bug in kiwix-desktop's source publishing step
veloman-yunkan Dec 17, 2024
a5a6ba1
Fixed kiwix-desktop Windows package name generation
veloman-yunkan Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ def create_desktop_image(make_release):
elif platform.system() == "Windows":
archive_basename = "kiwix-desktop_windows_x64_{}".format(postfix)
working_dir = INSTALL_DIR / archive_basename
build_path = working_dir + ".zip"
build_path = Path(str(working_dir) + ".zip")
app_name = build_path.name
command = [
"python",
Expand Down
4 changes: 2 additions & 2 deletions kiwixbuild/dependencies/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ def _make_dist(self, context):
*neutralEnv("git_command"),
"archive",
"-o",
f"{self.build_path}/{self.target_full_name()}.tar.gz",
f"--prefix={self.target_full_name()}/",
f"{self.build_path}/{self.target.full_name()}.tar.gz",
f"--prefix={self.target.full_name()}/",
"HEAD",
]
run_command(command, self.source_path, context)
Expand Down
Loading