Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under Windows builds are forced to release mode #779

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Under Windows builds are forced to release mode #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kiwixbuild/dependencies/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,9 @@ class MesonBuilder(Builder):

@property
def build_type(self):
if platform.system() == "Windows":
return "release"

return "release" if option("make_release") else "debug"

@property
Expand Down
4 changes: 2 additions & 2 deletions kiwixbuild/dependencies/kiwix_desktop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ class Builder(QMakeBuilder):
@property
def make_targets(self):
if platform.system() == "Windows":
yield "release-all" if option("make_release") else "debug-all"
yield "release-all"
else:
yield from super().make_targets

@property
def make_install_targets(self):
if platform.system() == "Windows":
yield "release-install" if option("make_release") else "debug-install"
yield "release-install"
else:
yield "install"

Expand Down
2 changes: 1 addition & 1 deletion kiwixbuild/versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

# This is the "version" of the whole base_deps_versions dict.
# Change this when you change base_deps_versions.
base_deps_meta_version = "09"
base_deps_meta_version = "10"

base_deps_versions = {
"zlib": "1.2.12",
Expand Down
Loading