Setup kiwix-destkop signature on Windows. #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgautierfr
force-pushed
the
kiwix-desktop_signing
branch
3 times, most recently
from
48b4edb to
71a8e96
Compare
mgautierfr
force-pushed
the
kiwix-desktop_signing
branch
2 times, most recently
from
538a10f to
ba77726
Compare
Default version of signtool in PATH does not work properly with our CKA. We could also load an SDK's env batch file instead but setting this on the workflow is more maintainable as we'll get a clear missing file error on GA Image change
mgautierfr
force-pushed
the
kiwix-desktop_signing
branch
from
a8edfd4 to
8b9d9f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #713