Skip to content

Commit

Permalink
Use specific version of signtool
Browse files Browse the repository at this point in the history
Default version of signtool in PATH does not work properly with our CKA.
We could also load an SDK's env batch file instead but setting this on the workflow
is more maintainable as we'll get a clear missing file error on GA Image change
  • Loading branch information
rgaudin authored and mgautierfr committed Aug 29, 2024
1 parent de90c6f commit 8b9d9f8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/releaseNigthly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ jobs:
run: |
python .github\\scripts\\build_release_nightly.py
env:
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.22621.0/x86/signtool.exe"
SSH_KEY: ${{ runner.temp }}/id_rsa
- name: Upload failure logs
if: failure()
Expand Down
2 changes: 1 addition & 1 deletion scripts/package_kiwix-desktop_windows.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
# We assume here that signtool and certificate are properly configured.
# Env var `SIGNTOOL_THUMBPRINT` must contain thumbprint of the certificate to use.
command = [
"signtool.exe",
os.getenv("SIGNTOOL_PATH", "signtool.exe"),
"sign",
"/fd",
"sha256",
Expand Down

0 comments on commit 8b9d9f8

Please sign in to comment.