Skip to content

Commit

Permalink
Under Windows builds are forced to release mode
Browse files Browse the repository at this point in the history
base_deps_meta_version was bumped so that the base dependencies archives for CI
workflows are recreated (we need only the Windows flavours of the
archives updated but such surgical intervention is not supported).
  • Loading branch information
veloman-yunkan committed Nov 22, 2024
1 parent 6cb347c commit 1c69945
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions kiwixbuild/dependencies/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,9 @@ class MesonBuilder(Builder):

@property
def build_type(self):
if platform.system() == "Windows":
return "release"

return "release" if option("make_release") else "debug"

@property
Expand Down
4 changes: 2 additions & 2 deletions kiwixbuild/dependencies/kiwix_desktop.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ class Builder(QMakeBuilder):
@property
def make_targets(self):
if platform.system() == "Windows":
yield "release-all" if option("make_release") else "debug-all"
yield "release-all"
else:
yield from super().make_targets

@property
def make_install_targets(self):
if platform.system() == "Windows":
yield "release-install" if option("make_release") else "debug-install"
yield "release-install"
else:
yield "install"

Expand Down
2 changes: 1 addition & 1 deletion kiwixbuild/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

# This is the "version" of the whole base_deps_versions dict.
# Change this when you change base_deps_versions.
base_deps_meta_version = "09"
base_deps_meta_version = "10"

base_deps_versions = {
"zlib": "1.2.12",
Expand Down

0 comments on commit 1c69945

Please sign in to comment.