Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the README file to show the required Java version to compile the project. #110

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Jun 26, 2024

Setting the JAVA version to 17 is a prerequisites to compile the project. Since now our project is compatible with Android 14(SDK 34) which requires version 8.4 of Gradle, and this Gradle version requires java 17 to run. So it should be added in the readme file so that user will not face this issue while building the binding. This is the only prerequisite to compile the project.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (29f194f) to head (3b103f6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #110   +/-   ##
=========================================
  Coverage     93.23%   93.23%           
  Complexity      237      237           
=========================================
  Files            47       47           
  Lines           325      325           
  Branches          3        3           
=========================================
  Hits            303      303           
  Misses           19       19           
  Partials          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 7bf2836 into main Jun 27, 2024
4 checks passed
@kelson42 kelson42 deleted the updated_readme_for_java_version branch June 27, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants