Fully Annotate Library and Mark as PEP-561-compatible #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on feedback from Mypy.
Resolves `TypeError`s thrown by Mypyc-compiled code as a result of empty tuple assignment to an int-typed `level` parameter during superclass initialization.
TeoZosa
force-pushed
the
fully-annotate-library-and-mark-as-pep-561-compatible
branch
from
8b735f1 to
070b940
Compare
TeoZosa
added a commit
to TeoZosa/structlog-sentry-logger
that referenced
this pull request
Sep 12, 2021
|
Hi @TeoZosa I'm sorry for the late response. If you are still interested in finishing this PR, there are quite a lot of changes that happened recently, see this PR: For all changes see #79 Basically we released version Let me know if you are still interested in finishing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
My dependent logging library recently started compiling modules into C extensions via Mypyc (TeoZosa/structlog-sentry-logger#220). To compile the library successfully, I needed to modify
structlog-sentryas part of TeoZosa/structlog-sentry-logger#253.Changes:
SentryJSONProcessorinitialization parameters (and, in turn, explicitly passing those to superclass initialization)py.typedthe package source code directory to mark that thestructlog-sentrypackage supplies type informationReviewer:
Tagging @aexvir for review (@kiwicom/platform is no longer valid 😞 ).
Thanks in advance!
Note:
Feel free to change commit messages, etc. as you see fit :)