feat: add expandOnTileClick to AccordionSection #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Deploying orbit with
|
| Latest commit: |
9019919
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f73e20e8.orbit.pages.dev |
| Branch Preview URL: | https://devin-1734013936-add-expand.orbit.pages.dev |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
|
Storybook staging is available at https://kiwicom-orbit-devin-1734013936-add-expand-on-tile-click.surge.sh |
|
Size Change: +321 B (+0.07%) Total Size: 460 kB
ℹ️ View Unchanged
|
packages/orbit-components/src/Accordion/AccordionSection/index.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Accordion/AccordionSection/types.d.ts
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Accordion/AccordionSection/components/SectionHeader.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/Accordion/AccordionSection/components/SectionHeader.tsx
Outdated
Show resolved
Hide resolved
devin-ai-integration
bot
force-pushed
the
devin/1734013936-add-expand-on-tile-click
branch
from
93d5a0e to
9e66744
Compare
packages/orbit-components/src/Accordion/AccordionSection/components/SectionHeader.tsx
Outdated
Show resolved
Hide resolved
devin-ai-integration
bot
force-pushed
the
devin/1734013936-add-expand-on-tile-click
branch
from
9e66744 to
a995633
Compare
mvidalgarcia
force-pushed
the
devin/1734013936-add-expand-on-tile-click
branch
from
a995633 to
64881d4
Compare
|
@CallstackAI review |
|
@CallstackAI review full |
devin-ai-integration
bot
force-pushed
the
devin/1734013936-add-expand-on-tile-click
branch
from
4f76eb3 to
7b03581
Compare
mvidalgarcia
force-pushed
the
devin/1734013936-add-expand-on-tile-click
branch
from
7b03581 to
9019919
Compare
mvidalgarcia
approved these changes
Dec 17, 2024
- Allows entire header section to be clickable for expansion - Maintains backward compatibility with button-based expansion - Adds cursor-pointer styling when header is clickable - Includes keyboard navigation support for accessibility - Includes tests and storybook examples Closes FEPLT-2180 Co-Authored-By: Jozef Képesi <[email protected]>
mvidalgarcia
force-pushed
the
devin/1734013936-add-expand-on-tile-click
branch
from
9019919 to
043c509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mobile-first interaction to AccordionSection component by implementing expandOnTileClick prop.
Closes FEPLT-2180
Link to Devin run: https://app.devin.ai/sessions/7f5e6966a6ab4b08a495ed623bc32d1b
✨
Description by Callstackai
This PR introduces a new
expandOnTileClickprop to theAccordionSectioncomponent, allowing the entire header to be clickable for expansion, while maintaining backward compatibility with the existing button-based expansion. It also includes keyboard navigation support and tests for the new functionality.Diagrams of code changes
sequenceDiagram participant User participant AccordionSection participant SectionHeader participant Accordion Note over AccordionSection: New prop: expandOnTileClick alt expandOnTileClick=true User->>SectionHeader: Clicks anywhere on header SectionHeader->>SectionHeader: handleClick() SectionHeader->>Accordion: onExpand(sectionId) Accordion->>AccordionSection: Updates expanded state else expandOnTileClick=false User->>SectionHeader: Clicks "Open" button SectionHeader->>SectionHeader: handleButtonClick() SectionHeader->>Accordion: onExpand(sectionId) Accordion->>AccordionSection: Updates expanded state end alt Keyboard Navigation User->>SectionHeader: Press Enter/Space SectionHeader->>SectionHeader: handleKeyDown() SectionHeader->>Accordion: onExpand(sectionId) Accordion->>AccordionSection: Updates expanded state endFiles Changed
expandOnTileClickfunctionality.AccordionSectionHeaderto handle click and keyboard events for the newexpandOnTileClickprop.AccordionSectionto accept the newexpandOnTileClickprop.expandOnTileClickprop.expandOnTileClickprop.expandOnTileClickfeature.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.md. See list of supported languages.