-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip now closes on ESC key press #4545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-dsil-close-tooltip-esc.surge.sh |
Size Change: +336 B (+0.07%) Total Size: 460 kB
ℹ️ View Unchanged
|
Deploying orbit with Cloudflare Pages
|
sarkaaa
reviewed
Dec 12, 2024
packages/orbit-components/src/primitives/TooltipPrimitive/components/TooltipWrapper.tsx
Show resolved
Hide resolved
sarkaaa
reviewed
Dec 12, 2024
Just minor code organization
DSil
force-pushed
the
dsil/close-tooltip-esc
branch
from
December 12, 2024 13:50
bb0b0e1
to
2961407
Compare
sarkaaa
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also did some cleanup by moving a component to an external file.
I tried to use useDismiss from floating-ui but there were some conflicts with accepting other events so I ended up just hardcoding an event listener.
For the tests, I used
toBeVisible
because it asserts CSS, that changes immediately toinvisible
. There is a delay on the re-render, so we would have to wait before usingtoBeInTheDocument
FEPLT-2159