-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NavigationBar): allow for transparent background when at the top… #4542
base: master
Are you sure you want to change the base?
Conversation
bottomStyle === "shadow" && "shadow-fixed", | ||
bottomStyle === "border" && "border-cloud-normal border-b", | ||
shown ? "translate-y-0" : "tb:-translate-y-1600 -translate-y-xxxl", // As defined on the const above | ||
!isTransparentBg && bottomStyle === "shadow" && "shadow-fixed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only apply the existing bottomStyle
logic when the background is not transparent.
18a7fb8
to
6b370b4
Compare
Deploying orbit with Cloudflare Pages
|
6b370b4
to
b35a63b
Compare
Storybook staging is available at https://kiwicom-orbit-rcsl-navbar-transparent-at-top.surge.sh |
Size Change: +161 B (+0.04%) Total Size: 460 kB
ℹ️ View Unchanged
|
1969ec3
to
820f88b
Compare
820f88b
to
4fca415
Compare
There's something odd about this 🤔 If I have Untitled.mov |
shown ? "translate-y-0" : "tb:-translate-y-1600 translate-y-[-52px]", // As defined on the const above | ||
bottomStyle === "shadow" && "shadow-fixed", | ||
bottomStyle === "border" && "border-cloud-normal border-b", | ||
shown ? "translate-y-0" : "tb:-translate-y-1600 -translate-y-xxxl", // As defined on the const above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xxxl is deprecated, so we should keep the hardcoded value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was the auto-formatting that did this, I tried many times to bypass it and looks like I failed in my last push 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get rid of that long deprecated xxxl token asap 😌
… of the screen This was requested on Slack.
4fca415
to
9770931
Compare
I think something was possibly missing for the I noticed that before but somehow thought it was some Storybook oddity. Glad you pushed me to take another look :) |
… of the screen
This was requested on Slack.
This Pull Request meets the following criteria:
For new components:
d.ts
files and are exported inindex.d.ts
Here's a preview of the change:
Screen.Recording.2024-12-05.at.15.15.57.mov