-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deconsider eslint-plugin package #4506
Conversation
Size Change: -51 B (-0.01%) Total Size: 459 kB
ℹ️ View Unchanged
|
Storybook staging is available at https://kiwicom-orbit-dsil-deconsider-eslint-plugin.surge.sh |
Deploying orbit with Cloudflare Pages
|
71369ce
to
524bca9
Compare
What about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM 👍
If I understood correctly, that is for eslint to ignore the dist folder of that package. Since we are not removing the package yet, I understood we still need to ignore it. Otherwise it might trigger lint warnings in built files in that dist folder |
524bca9
to
ae2842a
Compare
This marks the repository as private, so it is not considered by lerna for the release process.
It also removes all the references in docs and usage of the plugin across the repository.
FEPLT-2083