-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Stories to CSF3 - Batch 8 #4484
Conversation
Storybook staging is available at https://kiwicom-orbit-domi-migrate-stories-to-csf-3-batch-8.surge.sh |
Size Change: -2 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
Deploying orbit with Cloudflare Pages
|
2b52d9d
to
f53eae6
Compare
|
||
export const Default: Story = { | ||
render: ({ completedSteps, steps, ...args }) => ( | ||
<Wizard {...args} activeStep={completedSteps} completedSteps={completedSteps}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I excluded activeStep
from controls/args as before we have been setting argType for activeStep
dynamically based on the value of completedSteps
and steps
. Unfortunately, this is not possible with CSF3 (and it seems to me that it's not currently working correctly on master either 🤔).
I also hardcoded steps
because we have also been setting value of completedSteps
dynamically based on the length of steps
. With hardcoded value of steps, we can just set argType of completedSteps
. And then we can calculate value of activeStep
which can be <= completedSteps
but I think it's fine to always have = completedSteps
.
EDIT: In the end I added range also for activeStep
with the restriction that if the activeStep
is higher than completedSteps
, the value of completedSteps
will be passed to activeStep
. But steps
are still hardcoded as we wouldn't be able to dynamically get the steps' length.
f53eae6
to
70be71d
Compare
...ages/orbit-components/src/primitives/MobileDialogPrimitive/MobileDialogPrimitive.stories.tsx
Outdated
Show resolved
Hide resolved
201c79f
to
e412ea7
Compare
I think the
soo: I'm not sure if this sentence is 100% suitable, but the point overall is to inform the user that there are multiple viewports (mediumMobile...largeDesktop) and the changes in SB values don't have to be present as the user has switched to different device view. :D |
e412ea7
to
d04ccfc
Compare
d04ccfc
to
0ab57a3
Compare
Closes https://kiwicom.atlassian.net/browse/FEPLT-2079