-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize email icons generator #4445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying orbit with Cloudflare Pages
|
Size Change: -1 B (0%) Total Size: 455 kB
ℹ️ View Unchanged
|
Storybook staging is available at https://kiwicom-orbit-dsil-optimize-email-icons-generator.surge.sh |
DSil
force-pushed
the
dsil/optimize-email-icons-generator
branch
3 times, most recently
from
August 14, 2024 16:05
6fc1ba8
to
e2f39eb
Compare
mvidalgarcia
approved these changes
Aug 16, 2024
Sometimes we need to generate PNG from icons and add them to images.kiwi. The script to generate them was optimized and now generates the whole directory to be copied and pasted there.
DSil
force-pushed
the
dsil/optimize-email-icons-generator
branch
from
August 19, 2024 07:47
e2f39eb
to
edcde7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to generate PNG from icons and add them to images.kiwi. The script to generate them was optimized and now generates the whole directory to be copied and pasted there.
We should also have this process better documented, but I was unsure about where to document this. Something to be discussed soon™.
FEPLT-2093