Add & Update Typography tokens #4430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-dsil-typography-tokens.surge.sh |
|
Size Change: +64 B (+0.01%) Total Size: 446 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
aef52ba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://13984797.orbit.pages.dev |
| Branch Preview URL: | https://dsil-typography-tokens.orbit.pages.dev |
DSil
force-pushed
the
dsil/typography-tokens
branch
3 times, most recently
from
d7509e6 to
93657c3
Compare
...ages/orbit-design-tokens/src/dictionary/definitions/component/heading/heading-font-size.json
Show resolved
Hide resolved
docs/src/documentation/05-development/04-migration-guides/01-v16.mdx
Outdated
Show resolved
Hide resolved
docs/src/documentation/05-development/04-migration-guides/01-v16.mdx
Outdated
Show resolved
Hide resolved
DSil
force-pushed
the
rcsl/add-new-tokens
branch
from
a897565 to
d149983
Compare
DSil
force-pushed
the
dsil/typography-tokens
branch
2 times, most recently
from
add7513 to
5054c4b
Compare
DSil
force-pushed
the
rcsl/add-new-tokens
branch
from
d149983 to
0c6a187
Compare
DSil
force-pushed
the
dsil/typography-tokens
branch
from
3a88cc9 to
7d7005c
Compare
DSil
force-pushed
the
dsil/typography-tokens
branch
from
7d7005c to
4403de4
Compare
DSil
force-pushed
the
rcsl/add-new-tokens
branch
from
0c6a187 to
4d71306
Compare
BREAKING CHANGE: deprecated fontSize, lineHeight and textWeight tokens for Heading were removed. The replacement tokens can be used. Check the migration guide for more information.
BREAKING CHANGE: deprecated leading-heading class was removed.
DSil
force-pushed
the
dsil/typography-tokens
branch
from
4403de4 to
c4be941
Compare
Tests were deleted because they relied on deprecated tokens and we agreed not to test like this a while ago. BREAKING CHANGE: `type="title1"` should be replaced by `type="title0"` to avoid visual breaking change.
DSil
force-pushed
the
dsil/typography-tokens
branch
from
54b2bf9 to
d7d45a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened against #4401 so should be merged into it or to
masterafter the parent is merged.This updates the values as described in Figma and adds the new type.
The new
title0type corresponds to the previously existingtitle1styles, that were updated.This includes two breaking changes: deprecated heading tokens are removed and on the Heading component the
type="title1"should now betype="title0".Linux visual tests will be updated once the PR is ready to merge
FEPLT-2062